Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Fix: Added cases for ensureProtocol method; Fix project participant editing #999

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

curtisupshall
Copy link
Contributor

@curtisupshall curtisupshall commented Apr 12, 2023

Overview

  • Fixes a bug with editing project participants
  • Modifies the ensureProtocol utiltiy function to match the BioHub implementation

Testing Procedure

  1. Attempt to edit a project's participants in dev. It should fail.
  2. git checkout ensure-protocol
  3. You should now be able to edit project participants.

@curtisupshall curtisupshall changed the title Added cases for ensureProtocol method; Fix project participant editing Hot Fix: Added cases for ensureProtocol method; Fix project participant editing Apr 12, 2023
@curtisupshall curtisupshall requested a review from NickPhura April 12, 2023 00:44
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #999 (87dd774) into dev (23ebcb9) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##              dev     #999      +/-   ##
==========================================
+ Coverage   68.11%   68.12%   +0.01%     
==========================================
  Files         378      378              
  Lines       11723    11730       +7     
  Branches     1987     1990       +3     
==========================================
+ Hits         7985     7991       +6     
  Misses       3290     3290              
- Partials      448      449       +1     
Impacted Files Coverage Δ
...c/repositories/project-participation-repository.ts 83.33% <ø> (ø)
app/src/utils/Utils.ts 74.62% <87.50%> (+1.29%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AlfredRosenthal AlfredRosenthal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🕶️

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@curtisupshall curtisupshall merged commit eb001b6 into dev Apr 13, 2023
@curtisupshall curtisupshall deleted the ensure-protocol branch April 13, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants