-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHBC-2300: Apply 'Viewer' and 'Editor' Permissions to Project / Survey Views #1000
Conversation
@curtisupshall Just skimmed what you have here, looks pretty good so far. A few thoughts, semi jumbled. It might be ideal to turn that participant guard context into something more generic, like (I think the only funny project route atm is the edit one, as it doesn't fall under the Overall I think its similar to the work you did with the project/survey contexts really and fixing the routers a bit in the process, etc. |
Hmm, now I wonder if
This was my initial thinking; I wrote the
Yup, agreed. |
Lets chat in Discord. I suspect we are on the same track tbh and its mostly just a semantics thing. |
Codecov Report
@@ Coverage Diff @@
## dev #1000 +/- ##
==========================================
- Coverage 68.06% 67.90% -0.17%
==========================================
Files 378 380 +2
Lines 11727 11821 +94
Branches 1990 2006 +16
==========================================
+ Hits 7982 8027 +45
- Misses 3297 3343 +46
- Partials 448 451 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Fixed by #999. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally works well, no issues noticed. 🐈
Overview
As a Project Lead, I want to make sure that people I’ve invited to my team can only see the functions their role allows them to so they aren’t getting confused as to why some functionality appears broken.
Links to Jira tickets
Description of relevant changes
Testing Procedures
/details
to/edit
. It should:/details
to/users
. It should:/details
to/edit
. It should:/{surveyId}/details
to/create
. It should:/details
to/users
. It should: