Feature/vdyp 305 #47
Feature/vdyp 305 #47
Conversation
…RI primary layer into VDYP primary layer
…could not be found
…wer if the solver couldn't find an exact one
… Primary processing
…ariables' into feature/VDYP-305
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| var resultPerSpecies = new HashMap<String, Float>(); | ||
|
|
||
| for (float x = -3.9f; x <= 2; x += 0.01) { |
Check failure
Code scanning / CodeQL
Implicit narrowing conversion in compound assignment High test
smithkm
force-pushed
the
feature/VDYP-305
branch
from
243e705 to
851bae9
Compare
|
| @@ -82,6 +96,17 @@ public abstract class VdypStartApplication<P extends BaseVdypPolygon<L, Optional | |||
| map.put("Y", 9); | |||
| }); | |||
|
|
|||
| // TODO Should probably handle this with enums instead for clarity. | |||
There was a problem hiding this comment.
I've added ca.bc.gov.nrs.vdyp.model.DebugSettings class in common and implemented ca.bc.gov.nrs.vdyp.forward.model.ForwardDebugSettings that might prove to be a better way to implement this.
| @@ -729,6 +792,16 @@ public float estimatePercentForestLand(P polygon, Optional<L> vetLayer, L primar | |||
| protected static final ValueOrMarker.Builder<Float, Boolean> FLOAT_OR_BOOL = ValueOrMarker | |||
| .builder(Float.class, Boolean.class); | |||
|
|
|||
| public static final int UTIL_ALL = UtilizationClass.ALL.index; | |||
There was a problem hiding this comment.
It seems like we're duplicating these constants (this plus next three) all over the place - maybe put them in UtilizationClass?
There was a problem hiding this comment.
That or maybe switching to using the enum directly instead of the index. Maybe a UtilizationVector class instead of or subclassing Coefficients.
| layer.getWholeStemVolumeByUtilization().setCoe(UTIL_SMALL, volumeSum); | ||
| } | ||
|
|
||
| // EMP085 |
There was a problem hiding this comment.
Should note that this can be called only once the ALL lh and qmd values are set for the species. A similar comment applies to each of the following methods.
| float logit = // | ||
| a0 + // | ||
| a1 * coast + // | ||
| a2 * layer.getBreastHeightAge().orElse(0f) + // |
There was a problem hiding this comment.
Why the check for breast height age being present? The original FORTRAN code doesn't do this, at least explicitly.
| ); | ||
| } | ||
|
|
||
| public void computeUtilizationComponentsPrimary( |
There was a problem hiding this comment.
Add comment indicating FORTRAN routine - YUC1?
| /** | ||
| * Apply compatibility variables to all but volume | ||
| */ | ||
| NO_VOLUME, // 1 |
Feature/input param comp
No description provided.