Monorepo #52
Merged
Monorepo #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The duplication Sonar is reporting is in code that was already in the repo but has moved. I've tried to eliminate it but a lot of it seems to be not completely duplicate so much as a repeating pattern with different values. I can't see a good way to make sonar happy with those sections without making the code less readable. I can't see any way to tell Sonar to ignore the duplication other than to select the "Merge without waiting for requirements to be met (bypass branch protections) " option on the PR. |
mjunkin
approved these changes
Jul 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #50
Merge after #47.