HP-25: C4 Audit Fixes, Dynamic Fee Changes #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankurdubey521
changed the title
divyaN73
approved these changes
May 1, 2022
contracts/hyphen/LiquidityPool.sol
Outdated
| @@ -335,14 +345,14 @@ contract LiquidityPool is | |||
| * @param initialGas Gas provided initially before any calculations began | |||
| * @param tokenAddress Token address for which calculation needs to be done | |||
| * @param amount Amount of token to be transfered before deducting the fee | |||
| * @param tokenGasPrice Gas price in the token being transfered to be used to calculate gas fee | |||
| * @param nativeTokenPriceInTransferredToken Price of native token in terms of the token being transferred (multiplied base div), used to calculate gas fee | |||
| * @return [ amountToTransfer, lpFee, transferFeeAmount, gasFee ] | |||
| */ | |||
| function getAmountToTransfer( | |||
There was a problem hiding this comment.
Do these changes in new method getAmountToTransferV2 and same for sendFundsToUserV2
| expect((await ethers.provider.getBalance(owner.address)).gte(nativeBalance)).to.be.true; | ||
| }); | ||
|
|
||
| it("Should be able to withdraw liquidity", async function () { |
There was a problem hiding this comment.
Add a test case to verify if token manager was changed after contracts upgrades.
tomarsachin2271
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquidity Farming
Bug Fixes:
nft Infocan cause users'nft.unpaidRewardsto be permanently erased code-423n4/2022-03-biconomy-findings#135Liquidity Pool
Bug Fixes:
Features:
Liquidity Providers
Bugs Fixed
Token Manager
Features
excessStateTransferFeePercmappingPauser
Bugs Fixed
pausercan brick the contracts code-423n4/2022-03-biconomy-findings#137Misc