Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FUNCTION SETBASEGAS LACKS BOUNDS CHECK AND EVENT EMIT AFFECTS TRANSFER #192

Closed
code423n4 opened this issue Mar 16, 2022 · 1 comment
Closed

FUNCTION SETBASEGAS LACKS BOUNDS CHECK AND EVENT EMIT AFFECTS TRANSFER #192

code423n4 opened this issue Mar 16, 2022 · 1 comment
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Lines of code

https://github.com/code-423n4/2022-03-biconomy/blob/04751283f85c9fc94fb644ff2b489ec339cd9ffc/contracts/hyphen/LiquidityPool.sol#L119-L121
https://github.com/code-423n4/2022-03-biconomy/blob/04751283f85c9fc94fb644ff2b489ec339cd9ffc/contracts/hyphen/LiquidityPool.sol#L284

Vulnerability details

Impact

Executors can, unintentionally, send a huge amount of ETH

Proof of Concept

The function setBaseGas(uint128 gas)#LiquidityPool.sol should have bounds like MAXBASEGAS.
Even worse this function lacks of event emit.

As a result, executors can call sendFundsToUser and send enormous amount of ETH.

Tools Used

Manual code review

Recommended Mitigation Steps

Add bound checks and add an event emit
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Mar 16, 2022
code423n4 added a commit that referenced this issue Mar 16, 2022
@code423n4
peritoflores issue #192
6490443
@ankurdubey521 ankurdubey521 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Mar 30, 2022
@ankurdubey521 ankurdubey521 mentioned this issue Apr 28, 2022
Merged
@pauliax
Copy link
Collaborator

pauliax commented Apr 30, 2022

#8 (comment)

@pauliax pauliax closed this as completed Apr 30, 2022
@pauliax pauliax added the duplicate This issue or pull request already exists label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ankurdubey521 @pauliax @code423n4