Update how Redis URL is passed to Bull #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradvogel
requested changes
Sep 8, 2021
| @@ -120,8 +120,14 @@ class Queues { | |||
| if (queueConfig.createClient) | |||
| options.createClient = queueConfig.createClient; | |||
There was a problem hiding this comment.
This looks good. Though CI is failing the commit message because it doesn't conform to conventional commit standards: https://www.conventionalcommits.org/en/v1.0.0/. You can use a tool like https://www.npmjs.com/package/git-cz to generate one.
There was a problem hiding this comment.
Thanks for reviewing @bradvogel, I've updated the commit message.
jonmast
force-pushed
the
fix-bull-url-config
branch
from
7083e8f to
8057b29
Compare
Bull no longer allows passing the URL directly as the value of `options.redis`. Instead, pass URL as a separate argument when present. See OptimalBits/bull#2118 for additional context.
jonmast
force-pushed
the
fix-bull-url-config
branch
from
8057b29 to
81bf488
Compare
bradvogel
approved these changes
Sep 8, 2021
|
🎉 This PR is included in version 3.29.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
Bull no longer allows passing the URL directly as the value of
options.redis. Instead, pass URL as a separate argument when present.See OptimalBits/bull#2118 for additional
context.
Potential Risks
Specifying the Redis URL under the
rediskey instead ofurlwould have worked before's Bull's changes but this PR doesn't attempt to address that scenario.Test Plan
Using the
urlconfig with the latest version of Bull should demonstrate the fix. This should also work on older versions of Bull, the way it was previously handled here only worked by accident.Checklist
I've increased test coveragethere are no tests as far as I can see? Not sure what this is about