Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how Redis URL is passed to Bull #438

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Update how Redis URL is passed to Bull #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/server/queue/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,14 @@ class Queues {
if (queueConfig.createClient)
options.createClient = queueConfig.createClient;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Though CI is failing the commit message because it doesn't conform to conventional commit standards: https://www.conventionalcommits.org/en/v1.0.0/. You can use a tool like https://www.npmjs.com/package/git-cz to generate one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @bradvogel, I've updated the commit message.


if (typeof options.redis === 'string') delete options.redis;

const {Bull} = this._config;
queue = new Bull(name, options);
if (url) {
queue = new Bull(name, url, options);
} else {
queue = new Bull(name, options);
}
queue.IS_BULL = true;
}

Expand Down