Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The eval_buf Reads Beyond buf_len When buf Does Not End with \0 #379

Open
XuJiandong opened this issue Jan 8, 2025 · 0 comments
Open

The eval_buf Reads Beyond buf_len When buf Does Not End with \0 #379

XuJiandong opened this issue Jan 8, 2025 · 0 comments

Comments

@XuJiandong
Copy link

When the buf argument passed to eval_buf is not null-terminated (i.e., does not end with \0), the function may incorrectly read beyond the specified buf_len, potentially causing unintended behavior.

For an example and further details, see the pull request: XuJiandong#1.
XuJiandong added a commit to XuJiandong/ckb-js-vm that referenced this issue Jan 8, 2025
@XuJiandong
fix: uncaught exception return success
6d84f95 
see
bellard/quickjs#232
fix bug in eval_buf:
bellard/quickjs#379
@XuJiandong XuJiandong mentioned this issue Jan 8, 2025
Merged
XuJiandong added a commit to nervosnetwork/ckb-js-vm that referenced this issue Jan 8, 2025
@XuJiandong
Fix uncaught exception returning success (#29)
fdc0233 
* fix uncaught exception return success, see bellard/quickjs#232
* fix bug in eval_buf: bellard/quickjs#379
* cleanup test cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XuJiandong