Fix uncaught exception returning success #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a module throws exception, handle it and return error.
XuJiandong
force-pushed
the
cleanup-tests
branch
from
05952a7 to
73ae885
Compare
mohanson
approved these changes
Jan 8, 2025
see bellard/quickjs#232 fix bug in eval_buf: bellard/quickjs#379
XuJiandong
changed the title
XuJiandong
changed the title
XuJiandong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't catch exceptions when I upgrade version from 2023-12-09 to 2024-01-13 bellard/quickjs#232
eval_bufReads Beyondbuf_lenWhenbufDoes Not End with \0 bellard/quickjs#379