Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new OpenTX Tools screen / Add Menu / Use Virtual Events #252

Closed
wants to merge 7 commits into from

Conversation

frozenskys
Copy link
Contributor

This change moves the scripts to work with the new OpenTX 2.3.x Tools screen which standardises where to find your lua scripts and makes install much easier. It also introduces a menu meaning there is no need to page through the screens, and swaps to using the new virtual events standardising the button and dial events (same as #250 but slightly different approach.)

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Oct 9, 2019

Please note that you don't have to change all the paths, you can use the new chdir(path) instead. And please rebase on top of master to reduce the changes (61 files changed!!!).

Ideally, you could offer a new script that is installed into TOOLS and changes the entry point, so that your version would be compatible with the current one.

@mikeller
Copy link
Member

mikeller commented Oct 9, 2019

@frozenskys: I agree with @raphaelcoeffic that it will be better to leave the locations as they are, and use a 'forwarder' in SCRIPTS/TOOLS to invoke the script - some users will prefer to keep it as one of their telemetry screens.

Do the tools also work on X10 / X12 that currently do not have a good way to invoke scripts?

@raphaelcoeffic
Copy link
Member

Do the tools also work on X10 / X12 that currently do not have a good way to invoke scripts?

Yes, the tools menu is present on Horus targets.

Additionally, I have a PR in place for Widgets & events: opentx/opentx#6688
That's the next step.

@frozenskys
Copy link
Contributor Author

Ok - happy with the forwarder approach, using a folder is just an old habit from not cluttering the root of the drive, I will merge @raphaelcoeffic 's virtual event button code as that looks more complete than mine. What do you think of the menu instead of / as well as the page forward way of navigating?

@raphaelcoeffic
Copy link
Member

I like the main menu! Can I please have both 😋 more seriously, we probably need a way to make both doable, the question is how.

@frozenskys
Copy link
Contributor Author

Well if we are using two different launch scripts (for tools page and non tools page) like the bf.lua, we could set a global in the launch script to say which one to use? or we could just allow the menu to jump you in, and then page forwards and back once you have jumped in like normal, with exit taking you back to the menu?

@frozenskys
Copy link
Contributor Author

I have split this into 2 PRs one just adding the script to the tools screen, and one building on that and adding a menu for the tools screen script. Both are based off the Virtual Events change which needs merged first.

@frozenskys frozenskys closed this Oct 9, 2019
@frozenskys frozenskys deleted the opentx-tools branch October 9, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants