Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BF Scripts to OpenTX 2.3.x Tools screen #253

Merged
merged 3 commits into from
Oct 13, 2019

Conversation

frozenskys
Copy link
Contributor

Adds the betaflight scripts to the OpenTx Tools screen introduced in 2.3. Needs the virtual event changes merged from #250 first

This was split from #252

@raphaelcoeffic raphaelcoeffic changed the base branch from master to virtual-events October 9, 2019 22:08
@raphaelcoeffic
Copy link
Member

@frozenskys sorry for the disagreement, but could you please rebase on top of the current virtual-events branch? I rebased /squashed the commits with my back-and-forth. Please note that when you use the correct base branch, it makes it clearer on which PR yours is based.

@raphaelcoeffic
Copy link
Member

@mikeller @frozenskys I don't know what you think, but I'd say we should even remove /BF/bf.lua in favour of this one. There is no point in having the "standalone" startup script, as all the radios have the tools menu now, and it is really much better than going to the SD manager.

@mikeller
Copy link
Member

mikeller commented Oct 9, 2019

@raphaelcoeffic:

I don't know what you think, but I'd say we should even remove /BF/bf.lua in favour of this one.

Yes that makes sense. We could add an empty file named /BF/use_tools_menu_instead_of_this.txt for a couple of versions to help users make the switch. 😉

@frozenskys
Copy link
Contributor Author

@raphaelcoeffic sorry - I thought I had based off your branch - apologies I'm no git expert but I'll retry, and add the txt file :)

@raphaelcoeffic
Copy link
Member

No problem! You probably did, but then I rebased my stuff to simplify/squash things. So it’s now based on the old version.

@frozenskys
Copy link
Contributor Author

Help, not sure my rebase has worked :( any advice appreciated.

@raphaelcoeffic
Copy link
Member

@frozenskys in case you invite me, I can rebase it for you and push it to your branch.

@frozenskys
Copy link
Contributor Author

Invited thanks! - and be careful, it's a mess in there - git is not my friend... yet!

@raphaelcoeffic
Copy link
Member

@frozenskys done!

@mikeller should we just only have the text file extra? I thought removing /BF/bf.lua as well.

@mikeller
Copy link
Member

@raphaelcoeffic: Yes, the idea was to remove /BF/bf.lua and add the text file, so when a user goes there in the file explorer when they want to start the script they see the text file and know what to do.

@mikeller mikeller added this to the 1.5 milestone Oct 12, 2019
@mikeller mikeller merged commit 8874b62 into betaflight:virtual-events Oct 13, 2019
@mikeller mikeller mentioned this pull request Oct 13, 2019
@frozenskys frozenskys deleted the tools-screen branch October 13, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants