-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PIDs and simplified tuning #399
Merged
mikeller
merged 3 commits into
betaflight:master
from
klutvott123:update-simplified-tuning
Nov 1, 2021
Merged
Update PIDs and simplified tuning #399
mikeller
merged 3 commits into
betaflight:master
from
klutvott123:update-simplified-tuning
Nov 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutvott123
force-pushed
the
update-simplified-tuning
branch
from
October 10, 2021 17:22
b75cd1d
to
a016f67
Compare
klutvott123
changed the title
Update simplified_tuning.lua
Update PIDs and simplified tuning
Oct 10, 2021
@klutvott123 In 4.3 Configurator, Dmin becomes the value in the 'D' column, and the classic PID 'D' is shown in the 'D Max' column. This PR perhaps has it a different way around? |
klutvott123
force-pushed
the
update-simplified-tuning
branch
from
October 15, 2021 20:46
e16611f
to
224cc1b
Compare
Fixed. Thanks 👍 |
haslinghuis
previously approved these changes
Oct 18, 2021
klutvott123
force-pushed
the
update-simplified-tuning
branch
from
October 24, 2021 18:40
bb2bade
to
5e9700f
Compare
klutvott123
force-pushed
the
update-simplified-tuning
branch
from
October 25, 2021 12:15
5e9700f
to
0b89a05
Compare
mikeller
previously approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but needs a rebase.
Update max limits for pids and dMin
klutvott123
force-pushed
the
update-simplified-tuning
branch
from
October 31, 2021 05:50
0b89a05
to
1ae54d1
Compare
Rebased 👍 |
mikeller
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated descriptions and limits for simplified tuning.
Updated PID max limits to 250.
Renamed D to D Max.
betaflight/betaflight#10919
For testing betaflight-tx-lua-scripts_1.5.0.zip