Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PIDs and simplified tuning #399

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

klutvott123
Copy link
Member

@klutvott123 klutvott123 commented Oct 10, 2021

Updated descriptions and limits for simplified tuning.
Updated PID max limits to 250.
Renamed D to D Max.

betaflight/betaflight#10919

For testing betaflight-tx-lua-scripts_1.5.0.zip

@klutvott123 klutvott123 added this to the 1.6 milestone Oct 10, 2021
@klutvott123 klutvott123 force-pushed the update-simplified-tuning branch from b75cd1d to a016f67 Compare October 10, 2021 17:22
@klutvott123 klutvott123 changed the title Update simplified_tuning.lua Update PIDs and simplified tuning Oct 10, 2021
@ctzsnooze
Copy link
Member

@klutvott123 In 4.3 Configurator, Dmin becomes the value in the 'D' column, and the classic PID 'D' is shown in the 'D Max' column. This PR perhaps has it a different way around?

@klutvott123 klutvott123 force-pushed the update-simplified-tuning branch from e16611f to 224cc1b Compare October 15, 2021 20:46
@klutvott123
Copy link
Member Author

Fixed. Thanks 👍

haslinghuis
haslinghuis previously approved these changes Oct 18, 2021
mikeller
mikeller previously approved these changes Oct 31, 2021
Copy link
Member

@mikeller mikeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but needs a rebase.

@klutvott123
Copy link
Member Author

Rebased 👍

@mikeller mikeller merged commit bad5cb3 into betaflight:master Nov 1, 2021
@klutvott123 klutvott123 deleted the update-simplified-tuning branch November 26, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants