Fix morph interpolation #9927
Merged
Fix morph interpolation #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
approved these changes
Sep 26, 2023
Co-authored-by: Nicola Papale <[email protected]>
CGMossa
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
LGTM
I investigated this with @nicopap; As they attempted to mentor me through solving this.
I learned a lot, and thus able to review this a little bit.
Very impressive work! I still don't fully get it, but it is as far as I got myself!
nicopap
added
C-Bug
Co-authored-by: CGMossa <[email protected]>
A-Walrus
force-pushed
the
fix_jerky_morph
branch
from
523e0f7 to
4ef3ec7
Compare
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Fixes: bevyengine#9898 ## Solution Make morph behave like other keyframes, lerping first between start and end, and then between the current state and the result. ## Changelog Fixed jerky morph targets --------- Co-authored-by: Nicola Papale <[email protected]> Co-authored-by: CGMossa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes: #9898
Solution
Make morph behave like other keyframes, lerping first between start and end, and then between the current state and the result.
Changelog
Fixed jerky morph targets