-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding debug annotations to OpenGL objects. #1930
base: master
Are you sure you want to change the base?
Conversation
… GPU zones to achieve functionality very similar to Tracy, but on the GPU. V2
The semantics changed slightly. Lua side should check if |
@Beherith pls have a look |
Co-authored-by: sprunk <[email protected]>
Have you tried integrating the native Tracy GPU Profiling? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of notes on use of @return
.
* @param objectTypeIdentifier GLenum Specifies the type of object being labeled. | ||
* @param objectID GLuint Specifies the name or ID of the object to label. | ||
* @param label string A string containing the label to be assigned to the object. | ||
* @treturn nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@return
here (or just don't document a nil
return?)
/*** Gets the OpenGL Buffer ID | ||
* | ||
* @function VBO:GetID | ||
* @treturn number buffer ID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
@return number bufferID
Because @return <type> <name> [Optional description.]
.
It's a bit odd that returns get names, but that's the standard. I think it helps in multi-return cases.
GPU profiling is very different from CPU, and glDebugGroup is the standard there. NSight graphics gives you a much finer view over the performance counters within the GPU than tracy can, and gives more insight into optimization opportunities. |
As well as defining GPU zones to achieve functionality very similar to Tracy, but on the GPU. V2