Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lodash to remove prototype vulnerabilities #5

Closed
wants to merge 1 commit into from
Closed

Update lodash to remove prototype vulnerabilities #5

wants to merge 1 commit into from

Conversation

cheesestringer
Copy link

Fixes #4 by removing prototype vulnerabilities for lodash.assign and lodash.defaults.

https://ossindex.sonatype.org/component/pkg:npm/lodash.assign

https://ossindex.sonatype.org/component/pkg:npm/lodash.defaults

@cheesestringer cheesestringer changed the title Update lodash to remove prototype vulnerabilities` Update lodash to remove prototype vulnerabilities Feb 4, 2019
@bholloway
Copy link
Owner

@cheesestringer sorry for the delay.

I'm inclined to remove the lodash dependency and just use Object.assign. The original code predates node@4 and so used lodash.

@bholloway
Copy link
Owner

@cheesestringer see #7.

Are you agreeable to closing this in favour of #7?

@bholloway bholloway mentioned this pull request Feb 13, 2019
Merged
@cheesestringer
Copy link
Author

Nice, yeah sounds good :)

@bholloway bholloway closed this Feb 13, 2019
@cheesestringer cheesestringer deleted the feature/update-lodash branch February 13, 2019 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cheesestringer @bholloway