Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash dependency #7

Merged
merged 1 commit into from
Feb 15, 2019
Merged

remove lodash dependency #7

merged 1 commit into from
Feb 15, 2019

Conversation

bholloway
Copy link
Owner

@bholloway bholloway commented Feb 13, 2019

Supercedes #5.

  • Instead of updating lodash lets just change it out for Object.assign().
  • Update dependencies, use exact versions

@bholloway bholloway force-pushed the remove-lodash-dependency branch from 1d4039b to d1180e9 Compare February 13, 2019 11:36
@bholloway
Copy link
Owner Author

@cheesestringer could you pls eyeball this for any silly errors.

There is an unrelated depencency update but they appear to be fairly safe semver jumps. I was planning to just risk it. Really need some automated tests.

I presume you are just using this via resolve-url-loader. However if you are also using the loader proper please let me know if you can test.

@cheesestringer
Copy link

Looks good!

Yeah, just consuming it through resolve-url-loader.

@bholloway bholloway merged commit e7c59a9 into master Feb 15, 2019
@bholloway bholloway deleted the remove-lodash-dependency branch February 15, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants