Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min node version to 14 #1634

Merged
merged 1 commit into from
May 2, 2023
Merged

Conversation

sappelhoff
Copy link
Member

closes #1350

not sure whether bids-validator/esbuild.mjs should be edited 🤔

any idea @rwblair?

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0cbefce) 83.17% compared to head (1dcd825) 83.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   83.17%   83.17%           
=======================================
  Files          91       91           
  Lines        3763     3763           
  Branches     1158     1158           
=======================================
  Hits         3130     3130           
  Misses        535      535           
  Partials       98       98           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sappelhoff sappelhoff requested a review from rwblair March 1, 2023 12:59
@nellh
Copy link
Member

nellh commented Mar 2, 2023

closes #1350

not sure whether bids-validator/esbuild.mjs should be edited thinking

any idea @rwblair?

The only reason to keep it back is if a consumer of the validator as a library needs support for an older version. I'd update it unless it's above the current Node.js LTS release (18 currently).

@sappelhoff
Copy link
Member Author

@sappelhoff
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump node requirements from 12 to 14 (for users and devs)
2 participants