Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min node version to 14 #1634

Merged
merged 1 commit into from
May 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-bids-examples.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 12
node-version: 14
- uses: actions/checkout@v3
with:
submodules: recursive
Expand Down
4 changes: 2 additions & 2 deletions bids-validator/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
couple of minutes please open [developer tools ](https://developer.chrome.com/devtools)
and report the error at [https://github.com/bids-standard/bids-validator/issues](https://github.com/bids-standard/bids-validator/issues).
1. Command line version:
1. Install [Node.js](https://nodejs.org) (at least version 12.12.0)
1. Install [Node.js](https://nodejs.org) (at least version 14.0.0)
1. Update `npm` to be at least version 7 (`npm install --global npm@^7`)
1. From a terminal run `npm install -g bids-validator`
1. Run `bids-validator` to start validating datasets.
Expand All @@ -51,7 +51,7 @@
1. Install [Pip](https://pip.pypa.io/en/stable/installing/) package manager for Python, if
not already installed.
1. From a terminal run `pip install bids_validator` to acquire the
[BIDS Validator PyPI package](https://pypi.org/project/bids-validator/)
[BIDS Validator PyPI package](https://pypi.org/project/bids-validator/)
or `conda install bids-validator` for the
[Conda package](https://anaconda.org/conda-forge/bids-validator).
1. Open a Python terminal and type: `python`
Expand Down
2 changes: 1 addition & 1 deletion bids-validator/esbuild.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ await esbuild.build({
path.join(process.cwd(), 'utils', 'consoleFormat.js'),
],
outdir: path.join(process.cwd(), 'dist', 'commonjs'),
target: 'node12',
target: 'node14',
bundle: true,
sourcemap: true,
platform: 'node',
Expand Down
2 changes: 1 addition & 1 deletion bids-validator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"url": "https://github.com/bids-standard/bids-validator.git"
},
"engines": {
"node": ">=12.12.0"
"node": ">=14.0.0"
},
"bin": {
"bids-validator": "bin/bids-validator"
Expand Down