fix E721 errors in linting (#1978)

samplesheets/io.py

@@ -281,7 +281,7 @@ def _get_zip_path(cls, inv_path, file_path):
     @classmethod
     def _get_study(cls, o):
         """Return study for a potentially unknown type of object"""
-        if type(o) == Study:
+        if isinstance(o, Study):
             return o
         elif hasattr(o, 'study'):
             return o.study
@@ -329,7 +329,7 @@ def _import_comments(cls, comments):
     @classmethod
     def _import_tuple_list(cls, tuples):
         """Get list of dicts from tuples for JSONField"""
-        if type(tuples) == dict:
+        if isinstance(tuples, dict):
             return [cls._import_multi_val(v) for v in tuples.values()]
         elif type(tuples) in [tuple, list]:
             return [cls._import_multi_val(v) for v in tuples]
@@ -407,7 +407,7 @@ def _import_materials(cls, materials, db_parent, obj_lookup):
                 'study': study,
                 'headers': m.headers,
             }
-            if type(db_parent) == Assay:
+            if isinstance(db_parent, Assay):
                 values['assay'] = db_parent
             # NOTE: Extract label stored as JSON since altamISA 0.1 update
             if m.extract_label:
@@ -462,7 +462,7 @@ def _import_processes(
                 'unique_name': p.unique_name,
                 'name_type': p.name_type,
                 'protocol': protocol,
-                'assay': db_parent if type(db_parent) == Assay else None,
+                'assay': db_parent if isinstance(db_parent, Assay) else None,
                 'study': study,
                 'performer': p.performer,
                 'perform_date': p.date if p.date else None,

samplesheets/models.py

@@ -119,16 +119,16 @@ def get_study(self):
             return self.assay.study
         elif hasattr(self, 'study') and self.study:
             return self.study
-        elif type(self) == Study:
+        elif isinstance(self, Study):
             return self
 
     def get_project(self):
         """Return associated project"""
-        if type(self) == Investigation:
+        if isinstance(self, Investigation):
             return self.project
-        elif type(self) == Study:
+        elif isinstance(self, Study):
             return self.investigation.project
-        elif type(self) == Protocol:
+        elif isinstance(self, Protocol):
             return self.study.investigation.project
         elif type(self) in [Assay, GenericMaterial, Process]:
             if self.study:

samplesheets/utils.py

@@ -140,7 +140,7 @@ def get_isa_field_name(field):
     :param field: Field of an ISA Django model
     :return: String
     """
-    if type(field) == dict:
+    if isinstance(field, dict):
         return field['name']
     return field
 

setup.cfg

@@ -2,7 +2,7 @@
 max-line-length = 80
 exclude = .tox,.git,*/migrations/*,*/static/CACHE/*,docs_manual,
           node_modules,src/*,config/*,versioneer.py,env/*,.venv,_version.py
-ignore = E203, E266, E501, F405, W503, W504, C901, E721
+ignore = E203, E266, E501, F405, W503, W504, C901
 max-complexity = 18
 select = B,C,E,F,W,T4,B9