Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 E721 complaints after Python upgrade #1978

Closed
mikkonie opened this issue Aug 7, 2024 · 1 comment
Closed

Fix flake8 E721 complaints after Python upgrade #1978

mikkonie opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Aug 7, 2024

These should be fixed. I believe they are the result of Python version upgrades. I encountered them while doing #1922.

For now I'll just add E721 to ignore. Note: Remove after fixing these :)

./samplesheets/io.py:284:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/io.py:332:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/io.py:410:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/io.py:465:39: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/models.py:122:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/models.py:127:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/models.py:129:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/models.py:131:14: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
./samplesheets/utils.py:143:8: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: samplesheets Issue in the samplesheets app labels Aug 7, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Aug 7, 2024
@mikkonie mikkonie self-assigned this Aug 7, 2024
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: samplesheets Issue in the samplesheets app internal Changes invisible to the user or APIs (e.g. refactoring and optimization)
Projects
None yet
Development

No branches or pull requests

1 participant