-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests for multi-tenancy #145
Conversation
c459710
to
7493545
Compare
641a76a
to
f977961
Compare
065e9fd
to
c680f5a
Compare
c680f5a
to
6d0c98d
Compare
6d0c98d
to
3669963
Compare
830c01d
to
f0f77f7
Compare
f0f77f7
to
1d73209
Compare
test/bats/plugin-test.bats
Outdated
@@ -206,6 +206,69 @@ SLEEP_TIME=1 | |||
assert_success | |||
} | |||
|
|||
@test "namespaced sbom/notary/cosign/licensechecker/schemavalidator verifiers test" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a note that the other all-in-one test is already very flaky. The concurrent oras store issue has a higher chance of being triggered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the note! It did fail quite often recently, I added namespaced test to all-in-one setup so that we can cover most namespaced resources to increase our confidence on multi-tenancy feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@binbin-li I'm wondering if you think it's necessary to run an all-in-one test for this scenario. I'm concerned adding another all-in-one test will increase chances of test failures. Is there a part of all-in-one test unique to multi-tenancy that cannot be covered by a single verifier test?
f977961
to
80c51d1
Compare
1d73209
to
a6d87b7
Compare
ce2415f
to
758e479
Compare
a6d87b7
to
170a078
Compare
170a078
to
f0df760
Compare
…t#1428) Co-authored-by: Akash Singhal <[email protected]>
…t#1433) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-project#1440) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4726003
to
2b6c557
Compare
Description
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change