-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests for multi-tenancy [multi-tenancy PR 12] #1429
Conversation
65dbb3a
to
26f45c9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1429 +/- ##
==========================================
- Coverage 66.76% 66.74% -0.03%
==========================================
Files 116 119 +3
Lines 6030 6134 +104
==========================================
+ Hits 4026 4094 +68
- Misses 1620 1659 +39
+ Partials 384 381 -3 ☔ View full report in Codecov by Sentry. |
cf0ed11
to
c459710
Compare
830c01d
to
f0f77f7
Compare
f0f77f7
to
1d73209
Compare
1d73209
to
a6d87b7
Compare
a6d87b7
to
170a078
Compare
170a078
to
f0df760
Compare
@binbin-li cross posting discussion we were having in your fork's PR. Left another comment: https://github.com/binbin-li/ratify/pull/145/files#r1589761430 |
Following on the main PR. That's valid concern on the test failure. I'll add the basic test case covering the multi-tenancy scenario. Thanks for calling it out! |
4726003
to
2b6c557
Compare
Added a test covering notation and cosign verifiers which will cover both cert/key fetching in KMP. And we run the validation for notation and cosign separately which could avoid the testing failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. lgtm
@binbin-li Side question: What is the guidance moving forward when we need to add e2e tests. Do we target clustered or namespaced scenarios or do we have to do both? |
good question. I think we can keep focusing on cluster-wide scenarios. But if the change involves multi-tenancy or namespace, then we should add or update namespaced tests. |
…roject#1429) Signed-off-by: akashsinghal <[email protected]>
Description
What this PR does / why we need it:
This is the 12th PR for multi-tenancy support. Check the diff between PR 11 and PR 12 at: binbin-li#145
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change