-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update - Patches for third party links used by Ariba #24010
Conversation
@bioconda-bot please fetch artifacts |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
I'm going to test locally, to verify patches worked |
Looks like everything is working correctly. I'm going to pin the version of Bowtie2 to be <2.4 (See for more info: #22836) |
Test version, since there are open Issues related to bowtie2 version info and it affects ariba
@bioconda-bot please fetch artifacts |
@bioconda-bot please label |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
@bioconda-bot please add label |
Retested, good to go
|
@bioconda-bot please merge Looks good @rpetit3 |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
This PR includes two patches for Ariba related to changes in API endpoints.
pubmlst_getter.patch
fixes broken PubMLST downloads due to a change in API endpoint.Original Issue: sanger-pathogens/ariba#304
Submitted Ariba PR: sanger-pathogens/ariba#305
ref_genes_getter.patch
fixes a change in CARD links that causes RGI to be downloading instead of CARDOriginal Issue: sanger-pathogens/ariba#301
Submitted Ariba PR: sanger-pathogens/ariba#303
This my first time submitting a PR with patches so any advice would be appreaciated. I generated the patches through GitHub by appending
.patch
to the PR link.https://github.com/sanger-pathogens/ariba/pull/303.patch
https://github.com/sanger-pathogens/ariba/pull/305.patch
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.