fix(analyzer): allow constructor with default parameters in noUseless…

…Constructor (#1954)

CHANGELOG.md

@@ -551,6 +551,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 - Fix [#1932](https://github.com/biomejs/biome/issues/1932) Allow redeclaration of type parameters in different declarations.
   Contributed by @keita-hino
 
+- Fix [#1945](https://github.com/biomejs/biome/issues/1945) Allow constructor with default parameters in `noUselessConstructor`
+
 ### Parser
 
 #### Bug fixes

crates/biome_js_analyze/src/analyzers/complexity/no_useless_constructor.rs

@@ -97,6 +97,19 @@ declare_rule! {
     /// ```
     ///
     /// ```ts
+    /// class D {
+    ///   constructor(public arg: number){}
+    /// }
+    ///
+    /// class F extends D {
+    ///   // constructor with default parameters are allowed.
+    ///   constructor(arg = 4) {
+    ///     super(arg)
+    ///   }
+    /// }
+    /// ```
+    ///
+    /// ```ts
     /// @Decorator
     /// class C {
     ///     constructor (prop: number) {}
@@ -227,6 +240,14 @@ fn is_delegating_initialization(
             let param = param.ok()?;
             let arg = arg.ok()?;
             match (param, arg) {
+                (
+                    AnyJsConstructorParameter::AnyJsFormalParameter(
+                        AnyJsFormalParameter::JsFormalParameter(param),
+                    ),
+                    _,
+                ) if param.initializer().is_some() => {
+                    return Some(false);
+                }
                 (
                     AnyJsConstructorParameter::JsRestParameter(param),
                     AnyJsCallArgument::JsSpread(arg),

crates/biome_js_analyze/tests/specs/complexity/noUselessConstructor/valid.ts

@@ -25,3 +25,9 @@ class G extends B {
       super(bar);
     }
 }
+
+class H extends B {
+    constructor(name = "default") {
+      super(name);
+    }
+}

crates/biome_js_analyze/tests/specs/complexity/noUselessConstructor/valid.ts.snap

@@ -32,6 +32,12 @@ class G extends B {
     }
 }
 
+class H extends B {
+    constructor(name = "default") {
+      super(name);
+    }
+}
+
 ```
 
 

website/src/content/docs/internals/changelog.md

@@ -557,6 +557,8 @@ our [guidelines for writing a good changelog entry](https://github.com/biomejs/b
 - Fix [#1932](https://github.com/biomejs/biome/issues/1932) Allow redeclaration of type parameters in different declarations.
   Contributed by @keita-hino
 
+- Fix [#1945](https://github.com/biomejs/biome/issues/1945) Allow constructor with default parameters in `noUselessConstructor`
+
 ### Parser
 
 #### Bug fixes

website/src/content/docs/linter/rules/no-useless-constructor.md

@@ -171,6 +171,19 @@ class C {
 }
 ```
 
+```ts
+class D {
+  constructor(public arg: number){}
+}
+
+class F extends D {
+  // constructor with default parameters are allowed.
+  constructor(arg = 4) {
+    super(arg)
+  }
+}
+```
+
 ```ts
 @Decorator
 class C {