Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analyzer): allow constructor with default parameters in noUselessConstructor #1954

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

togami2864
Copy link
Contributor

Summary

close #1945

Test Plan

added test cases and snapshots

@github-actions github-actions bot added A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages labels Mar 2, 2024
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 9ff7749
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/65e5c3ae68fa520008c6536d
😎 Deploy Preview https://deploy-preview-1954--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Mar 2, 2024

CodSpeed Performance Report

Merging #1954 will not alter performance

⚠️ No base runs were found

Falling back to comparing togami2864:fix/1945 (9ff7749) with main (41f97ce)

Summary

✅ 93 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a new changelog entry before merging?

@github-actions github-actions bot added the A-Changelog Area: changelog label Mar 4, 2024
@togami2864 togami2864 merged commit 8150c8e into biomejs:main Mar 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-Linter Area: linter A-Website Area: website L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 noUselessConstructor triggered by constructor with default parameters
2 participants