refactor: enable needless_lifetimes clippy rule (#4973)

Cargo.toml

@@ -17,7 +17,6 @@ allow_attributes        = "deny"
 cargo_common_metadata   = "allow"
 empty_docs              = "allow" # there are some false positives inside biome_wasm
 multiple_crate_versions = "allow"
-needless_lifetimes      = "allow"
 
 # pedantic
 assigning_clones             = "warn"

crates/biome_analyze/src/syntax.rs

@@ -109,7 +109,7 @@ mod tests {
         nodes: Vec<RawLanguageKind>,
     }
 
-    impl<'a> QueryMatcher<RawLanguage> for &'a mut BufferMatcher {
+    impl QueryMatcher<RawLanguage> for &mut BufferMatcher {
         fn match_query(&mut self, params: MatchQueryParams<RawLanguage>) {
             self.nodes.push(
                 params

crates/biome_formatter/src/lib.rs

@@ -2054,7 +2054,7 @@ mod tests {
             }
         }
 
-        impl<'a> std::fmt::Display for DiagnosticPrinter<'a> {
+        impl std::fmt::Display for DiagnosticPrinter<'_> {
             fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
                 for diagnostic in self.diagnostics {
                     diagnostic.description(f)?;

crates/biome_grit_patterns/src/pattern_compiler/compilation_context.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::needless_lifetimes)]
 use grit_pattern_matcher::pattern::VariableSource;
 use grit_util::ByteRange;
 

crates/biome_yaml_parser/src/lexer/mod.rs

@@ -56,7 +56,7 @@ pub(crate) struct YamlLexer<'src> {
     context: YamlLexContext,
 }
 
-impl<'source> YamlLexer<'source> {
+impl YamlLexer<'_> {
     fn current_char(&self) -> Option<u8> {
         self.source.as_bytes().get(self.position).copied()
     }