Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable needless_lifetimes clippy rule #4973

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

unvalley
Copy link
Member

@unvalley unvalley commented Jan 26, 2025

Summary

This PR enables needless_lifetimes clippy rule that is default in Rust v1.84.0.

Test Plan

@github-actions github-actions bot added A-Parser Area: parser L-Grit Language: GritQL labels Jan 26, 2025
@unvalley unvalley changed the title refactor: enable needless_lifetime clippy rule refactor: enable needless_lifetimes clippy rule Jan 26, 2025
Copy link

codspeed-hq bot commented Jan 26, 2025

CodSpeed Performance Report

Merging #4973 will not alter performance

Comparing unvalley:use-needless-lifetime (1d6f724) with next (5184067)

Summary

✅ 95 untouched benchmarks

@github-actions github-actions bot added the A-Formatter Area: formatter label Jan 26, 2025
@github-actions github-actions bot added the A-Linter Area: linter label Jan 27, 2025
@unvalley unvalley marked this pull request as ready for review January 27, 2025 04:11
@unvalley unvalley merged commit e5d99df into biomejs:next Jan 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser L-Grit Language: GritQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants