Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash for Role is not using cyrptographic hash #2662

Closed
ManfredKarrer opened this issue Apr 6, 2019 · 1 comment
Closed

Hash for Role is not using cyrptographic hash #2662

ManfredKarrer opened this issue Apr 6, 2019 · 1 comment
Assignees
Labels
Milestone

Comments

@ManfredKarrer
Copy link
Contributor

The hash which is used at Role is useing hashCode instead of a cryptographic hash.
hashCode is not guaranteed to be determinisitic across JVM implementations and versions so we must not use that in any consensus relevant use case. The hash for Role seems to have not much usage atm but will likely get more at least for arbitrators, mediators and maybe seed node operators. So better to fix that before the mainnet launch...

@ManfredKarrer ManfredKarrer self-assigned this Apr 6, 2019
@ManfredKarrer ManfredKarrer added this to the v1.0.0 milestone Apr 6, 2019
@ManfredKarrer
Copy link
Contributor Author

The consequences with the change with the current data and network is that a because of the hash change a bonded role is not found anymore and interpreted as bonded reputation.
If a bonded role was locked up it cannot be revoked in the UI. So when we add this change there can be smaller confusions but it should not break consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant