Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cryptographic hash from protobuffer serialized data instead of hashCode #2665

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Use cryptographic hash from protobuffer serialized data instead of hashCode #2665

merged 1 commit into from
Apr 8, 2019

Conversation

ManfredKarrer
Copy link
Contributor

@ManfredKarrer ManfredKarrer commented Apr 7, 2019 •
edited
Loading

Fixes #2662

Let's wait with merge until we are sure when we want to deploy it.

@ManfredKarrer ManfredKarrer changed the title Use cryptographic hash from protobuffer serialized data instead of ha… Use cryptographic hash from protobuffer serialized data instead of hashCode Apr 7, 2019
@ManfredKarrer ManfredKarrer requested a review from sqrrm April 7, 2019 00:17
@ManfredKarrer ManfredKarrer added this to the v0.9.8 milestone Apr 7, 2019
@sqrrm
Copy link
Member

sqrrm commented Apr 7, 2019

I think it's worth getting this right. The change itself is simple and those that want to can upgrade testnet to get the monitoring right. Slightly annoying vs keeping this into live launch.

utACK

@ManfredKarrer ManfredKarrer marked this pull request as ready for review April 8, 2019 01:28
ripcurlx
ripcurlx approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit f4c65c4 into bisq-network:master Apr 8, 2019
@ManfredKarrer ManfredKarrer deleted the use-crypt-hash-at-role branch April 8, 2019 15:10
@ripcurlx ripcurlx mentioned this pull request May 3, 2019
Closed
@sqrrm sqrrm mentioned this pull request May 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

@sqrrm sqrrm Awaiting requested review from sqrrm

Assignees
No one assigned
Labels
in:dao
Projects
None yet
Milestone
v0.9.8
Development

Successfully merging this pull request may close these issues.
3 participants
@ManfredKarrer @sqrrm @ripcurlx