Add --useDevPrivilegeKeys option to enable usage of dev keys for testing #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mrosseel
commented
Dec 19, 2017
mrosseel
commented
- added parser option in both BisqAppMain and BisqExecutable
- made USE_DEV_PRIVILEGE_KEYS non-final
Signed-off-by: Mike Rosseel <[email protected]>
| "are overridden by a dev key pair. Features: Arbitration registration" + | ||
| " (alt+R at account), Alert/Update (alt+m), private message to a peer " + | ||
| "(click user icon and alt+r), filter/block offers by various data like" + | ||
| " offer ID (cmd + f)", false)); |
There was a problem hiding this comment.
This is not needed here.
| if(options.has(AppOptionKeys.USE_DEV_PRIVILEGE_KEYS)) { | ||
| DevEnv.USE_DEV_PRIVILEGE_KEYS = true; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not needed here.
But all the other places where the option keys are applied are missing.
|
Not complete for merge. See comments. Just follow other option keys to see where changes have to be applied. |
|
Ok, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.