Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 38 #1121

Closed
alvasw opened this issue Aug 1, 2022 · 5 comments
Closed

For Cycle 38 #1121

alvasw opened this issue Aug 1, 2022 · 5 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@alvasw
Copy link

alvasw commented Aug 1, 2022

Summary

Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):

  • BSQ requested: 8000
  • USD requested: 6000
  • BSQ rate: 0.75 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 37 #1097

Contributions delivered

Add contributions you have delivered and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column.

Title Team USD Link Notes
Set Java 11 as Compilation Target dev bisq-network/bisq2#408 We need to target Java 11 for Android Support.
build-logic: Set Kotlin Version Explicitly dev bisq-network/bisq2#412
build-logic: Download and Verify Electrum Binaries dev bisq-network/bisq2#413 The new BisqElectrumPlugin downloads and verifies the Electrum binaries for Linux, OSX, and Windows. The PGP public keys and the fingerprints of the Electrum developers are hardcoded in the plugin. Consumers of the plugin can set the electrumVersion property to specify the version.
Bundle Electrum Binaries with Bisq dev bisq-network/bisq2#414 Package the Electrum binaries after verifying the signatures and copy it to the Java resources.
Github Actions: Install Bitcoin Core on CI dev bisq-network/bisq2#417 The bitcoind integration tests depend on Bitcoin Core.
Run Bitcoind Integration Tests on CI dev bisq-network/bisq2#418 Check whether bitcoind is installed and run integration tests depending on its result.
ElectrumBinariesDownloader: Close all streams after download dev bisq-network/bisq2#420
Bisq-Plugin: Add gradlePluginPortal Repository dev bisq-network/bisq2#422
DaemonProcess: Log process start config dev bisq-network/bisq2#426
desktop/desktopapp: Target Java 17 dev bisq-network/bisq2#436 JPackage cannot sign the DMG image on Mac because the JavaFX 11 Mac dylib libraries are not signed. It's less work to target Java 17 (and JavaFx 17) instead of adapting the build process to sign the dylib libraries before creating and signing the DMG image.
Proof of Concept: Pricenode Extraction dev bisq-network/bisq#6292 PoC: https://github.com/alvasw/bisq-pricenode
PR Review: Add new bisq-pricenode build dev bisq-network/bisq-pricenode#4
PR Review: Add re-usable Gradle task postBuild dev bisq-network/bisq-gradle#1
Fix race condition in bitcoind unconfirmed txs dev bisq-network/bisq2#441
  • Move initialize and shutdown to BitcoindWallet
  • Bitcoind: Create custom JUnit Extension
  • Bitcoind: Use custom extension in integration tests
  • BitcoindInitialRegtestMiningTest: Wait until all blocks mined
  • BitcoindRegtestSetup: Make regtest block mining blocking
  • BitcoindSendUnconfirmedTest: Wait until tx broadcasted
Fix race condition in elementsd unconfirmed txs dev bisq-network/bisq2#444
  • ElementsdVin: Add missing peginWitnesses field
  • Elements: Make regtest block mining blocking
  • Elements: Move regtest classes to its own package
  • ElementsSendUnconfirmedTest: Wait until tx broadcasted
  • ElementsdVin: Add issuance field
CI: Install Elements Core and Run Integration Tests dev bisq-network/bisq2#445
  • Github Actions: Rename setup-bitcoin-core to install-wallets
  • Github Actions: Install Elements Core
  • Wallets: Enable Elements Integration tests (when elementsd installed)
PR Review: Add re-usable Gradle task postBuild dev bisq-network/bisq-gradle#1 Proof of Concept: Plugin - https://github.com/ghubstan/bisq-post-assemble-plugin/tree/convert_to_standalone_plugin
Proof of Concept: Plugin Consumption - https://github.com/alvasw/bisq-pricenode/tree/adjust-build-files-n-scripts
PR Review: Add bisq v1 post build plugin dev bisq-network/bisq-gradle#2 pluginManagement block was missing.
Bisq 2 Web UI: Add Bisq 2 repo as a Composite Build dev https://github.com/salokiam/bisq2-web-ui/pull/1
  • Make Gradle Wrapper executable
  • Update Gradle Wrapper to 7.5
  • Add Bisq 2 repo as a Composite Build
Add Bisq 2 identity module as a dependency dev https://github.com/salokiam/bisq2-web-ui/pull/2 JitPack was missing as a repository.
PR Review: Fix plugin management spec in settings.gradle dev bisq-network/bisq-pricenode#8
dev 6000 Total for items above.
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team labels Aug 1, 2022
@chimp1984
Copy link

ACK

@MwithM MwithM added this to the Cycle 38 milestone Aug 2, 2022
@ripcurlx
Copy link
Contributor

ripcurlx commented Aug 4, 2022

As dev team lead I approve this compensation request for dev based on #1121 (comment). Please submit your compensation request to the DAO for voting and post the transaction ID here afterwards. Thanks!

@alvasw
Copy link
Author

alvasw commented Aug 5, 2022

f217e0f8cb8b529597ec9f7f4ef76f2e1dc8178633f2fbe237fcc1bb3461bd3f

@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Issuance by Team:

team amount BSQ amount USD
dev 8000.00 6000.00

Total Issuance: 8000.00 BSQ (equivalent to: 6000.00 USD)

@MwithM
Copy link
Contributor

MwithM commented Aug 16, 2022

Closed as accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:dev https://bisq.wiki/Dev_Team was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Archived in project
Development

No branches or pull requests

4 participants