Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#178] Automate release process (2) #184

Closed
wants to merge 13 commits into from

Conversation

pmeinhardt
Copy link
Contributor

@pmeinhardt pmeinhardt commented Aug 1, 2019

Check out np for releasing Tickety-Tick ✌️

⚠️ Note: The webpack GitRevisionPlugin is not outputting the correct COMMITHASH and VERSION yet, because the npm/yarn version script runs just before commiting.

@pmeinhardt pmeinhardt force-pushed the feature/178-automate-release-process-2 branch from 89f505b to 8d6b7b2 Compare August 1, 2019 13:43
@pmeinhardt pmeinhardt added the work in progress This is currently being worked on label Aug 1, 2019
@pmeinhardt pmeinhardt force-pushed the feature/178-automate-release-process-2 branch from 8d6b7b2 to 7ba172d Compare August 1, 2019 15:59
@klappradla klappradla mentioned this pull request May 6, 2020
3 tasks
@klappradla
Copy link
Member

I think it makes sense to pick this up again for setting up the automation flow I roughly outlined in #178 (comment) @pmeinhardt. If we want to trigger build magic on CI based on pushing tags, utilizing yarn release and np could be a starting point.

Given we currently don't actually support Safari any more, I would probably already get rid of the extra parts for it.

@pmeinhardt
Copy link
Contributor Author

Thanks a ton @klappradla for looking into release automation. 💚

I'd actually be fine with dropping Safari support. It simplifies a lot of things (webpack config, repo structure, preferences… reduces extra abstractions in app initialization/React context…).

Also, it seems like a new, compatible Safari version would essentially be a completely different code base with Apple deciding to go "native app extensions" rather sticking to the WebExtension standards. #210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress This is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants