-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#178] Automate release process (2) #184
Conversation
- Add a new `bundle:safari` task - Add the BUNDLE task to the safari build script
- Use rimraf for cross os support
- Uses ghr (go) to draft the releases - Only build for tags
89f505b
to
8d6b7b2
Compare
8d6b7b2
to
7ba172d
Compare
I think it makes sense to pick this up again for setting up the automation flow I roughly outlined in #178 (comment) @pmeinhardt. If we want to trigger build magic on CI based on pushing tags, utilizing Given we currently don't actually support Safari any more, I would probably already get rid of the extra parts for it. |
Thanks a ton @klappradla for looking into release automation. 💚 I'd actually be fine with dropping Safari support. It simplifies a lot of things (webpack config, repo structure, preferences… reduces extra abstractions in app initialization/React context…). Also, it seems like a new, compatible Safari version would essentially be a completely different code base with Apple deciding to go "native app extensions" rather sticking to the WebExtension standards. #210 |
Check out
np
for releasing Tickety-Tick ✌️GitRevisionPlugin
is not outputting the correctCOMMITHASH
andVERSION
yet, because thenpm/yarn version
script runs just before commiting.