Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#178] Automate release process (3) #249

Closed
wants to merge 9 commits into from

Conversation

klappradla
Copy link
Member

@klappradla klappradla commented May 13, 2020

Edition three of #178

This is only a draft for further discussion on the topic. I did not want to override things in #184, as there are some slight adaptions of existing things there and we may want to directly compare them.

This is how a release of a random artifact from an example repo of mine looks like with the tooling in this PR:

Screenshot 2020-05-13 at 19 08 54

tools

  • np to create and push the git tag
  • ghr to create a release with artifacts on Github

additional tools

@klappradla klappradla force-pushed the feature/178-automate-release-process-3 branch 5 times, most recently from bb6300a to 67b8f0a Compare May 14, 2020 18:47
@klappradla
Copy link
Member Author

klappradla commented May 14, 2020

Learnings

  • Mozilla rejects versions with a - in them (e.g. v4.0.0-0)
    This means we should ideally use beta / alpha / pre etc. version names for our pre-releases.
  • np does not allow to input a custom version:
    Choosing Other (specify) to specify a custom version in the interactive UI does not show the successive prompt and then fails as no version was specified.

For the problem with np is submitted this issue as we did not find an explanation for this yet.

@klappradla klappradla force-pushed the feature/178-automate-release-process-3 branch from 47a1c61 to 26e26de Compare May 18, 2020 16:04
@pmeinhardt pmeinhardt force-pushed the feature/178-automate-release-process-3 branch 2 times, most recently from 3604f4c to bd7c2aa Compare June 30, 2020 21:19
@pmeinhardt
Copy link
Contributor

Still some things to do:

  1. Chrome version contains "unlisted" in manifest
  2. web-ext-submit still seems to fail even though the release successfully shows up on addons.mozilla.org afterwards.
Applying config file: ./package.json
Building web extension from /Users/pmeinhardt/Code/bitcrowd/tickety-tick/dist/firefox
Validating add-on [............................................................]
Validation results: https://addons.mozilla.org/en-US/developers/upload/dadcd36c29994780a060d14442a4b666
Signing add-on [...............................................................]
0
FAIL

o: The extension could not be signed
    at /Users/pmeinhardt/Code/bitcrowd/tickety-tick/node_modules/web-ext-submit/node_modules/web-ext/dist/web-ext.js:1:67620
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
    at F.execute (/Users/pmeinhardt/Code/bitcrowd/tickety-tick/node_modules/web-ext-submit/node_modules/web-ext/dist/web-ext.js:1:33970)

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@klappradla
Copy link
Member Author

Update

Turns out the <version>unlisted version name does not work for Chrome 😢 #255

package.json Outdated
@@ -55,6 +59,7 @@
"jsdom": "16.2.2",
"mini-css-extract-plugin": "^0.9.0",
"node-sass": "4.14.1",
"np": "https://github.com/dopecodez/np.git#54f3c8f",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: we can probably also move back to the stable version. Turns out the version name we wanted to have isn't https://semver.org/ compatible anyways 😉

@pmeinhardt pmeinhardt changed the base branch from master to main August 4, 2020 22:13
@klappradla klappradla force-pushed the feature/178-automate-release-process-3 branch from d7c1ae7 to d9f1a95 Compare October 8, 2020 16:30
@klappradla
Copy link
Member Author

Some rebase of hell 🔥

@klappradla
Copy link
Member Author

I did another field experiment with this branch 👨‍🌾: I wanted to release a new version... what in the end turned out to be two versions 🤯

Mozilla did some updates to their upload process - the manual one: one now has to manually select that one is uploading something to be released on their platform in contrast to "self hosting". Plus, they changed the name of the returned file when signing for the unlisted channel, so the cp command in our release script does not work any more 🙈

What we also did not take into account: for uploading the release to Mozilla's listed channel, we have to bundle it again. Otherwise it still has the unlisted in its name and Mozilla will reject it as there is already a release with this name.

@klappradla
Copy link
Member Author

Turns out Mozilla also has a problem with our submissions for self signing the extension - which we do to download the .xpi file for the release on Github: they also want to look at the source code there.

I haven't yet found out how to use the web-ext API to also include the source code in a way that Mozilla's reviewers can find it in the respective place.

@pmeinhardt pmeinhardt mentioned this pull request Nov 30, 2021
@klappradla
Copy link
Member Author

Considered done (finally 🎉 ) in #296

@klappradla klappradla closed this Apr 4, 2023
@klappradla klappradla deleted the feature/178-automate-release-process-3 branch April 4, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants