Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13999] Show estimated tax for taxable countries #5077

Merged

Conversation

jonashendrickx
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13999

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 25, 2024 14:04
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 67.78523% with 432 lines in your changes missing coverage. Please review.

Project coverage is 43.79%. Comparing base (c703390) to head (0535544).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...e/Services/Implementations/StripePaymentService.cs 2.08% 281 Missing and 1 partial ⚠️
...ices/Implementations/OrganizationBillingService.cs 7.40% 25 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs 7.40% 25 Missing ⚠️
...ling/Services/Implementations/SubscriberService.cs 25.00% 22 Missing and 2 partials ⚠️
src/Api/Billing/Controllers/InvoicesController.cs 0.00% 16 Missing ⚠️
src/Core/Billing/Extensions/CurrencyExtensions.cs 0.00% 9 Missing ⚠️
...izations/PreviewOrganizationInvoiceRequestModel.cs 0.00% 9 Missing ⚠️
...i/Billing/Controllers/AccountsBillingController.cs 0.00% 8 Missing ⚠️
src/Core/Services/Implementations/StripeAdapter.cs 14.28% 6 Missing ⚠️
...odels/Api/Responses/PreviewInvoiceResponseModel.cs 0.00% 5 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5077      +/-   ##
==========================================
+ Coverage   43.14%   43.79%   +0.65%     
==========================================
  Files        1424     1433       +9     
  Lines       65094    66344    +1250     
  Branches     5964     6044      +80     
==========================================
+ Hits        28085    29057     +972     
- Misses      35756    36035     +279     
+ Partials     1253     1252       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Logo
Checkmarx One – Scan Summary & Details0e172bb4-0890-417a-8c1a-e9cac9432baa

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Billing/Controllers/InvoicesController.cs: 16 Attack Vector
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301 Attack Vector
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 184 Attack Vector
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 169 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104 Attack Vector
LOW Missing_CSP_Header /src/Core/MailTemplates/Handlebars/AdminConsole/OrganizationUserRevokedForSingleOrgPolicy.html.hbs: 5 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 106
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 238
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 264
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 345
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 362
MEDIUM CSRF /src/Api/AdminConsole/Controllers/OrganizationUsersController.cs: 306

Copy link
Contributor

@cturnbull-bitwarden cturnbull-bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's looking good! I left only a few comments, mostly ⛏️ with a few higher ones.

@jonashendrickx jonashendrickx merged commit 94fdfa4 into main Dec 4, 2024
51 of 52 checks passed
@jonashendrickx jonashendrickx deleted the PM-13999-Show-estimated-tax-for-taxable-countries branch December 4, 2024 10:45
cturnbull-bitwarden added a commit that referenced this pull request Dec 4, 2024
@jonashendrickx jonashendrickx restored the PM-13999-Show-estimated-tax-for-taxable-countries branch December 4, 2024 14:29
jonashendrickx added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants