-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-13999] Show estimated tax for taxable countries #5077
Merged
jonashendrickx
merged 36 commits into
main
from
PM-13999-Show-estimated-tax-for-taxable-countries
Dec 4, 2024
Merged
[PM-13999] Show estimated tax for taxable countries #5077
jonashendrickx
merged 36 commits into
main
from
PM-13999-Show-estimated-tax-for-taxable-countries
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-Accounts' into PM-14892-Sales-Tax-Estimation-For-Accounts
…r-Accounts' into PM-14892-Sales-Tax-Estimation-For-Accounts
…r-Accounts' into PM-14892-Sales-Tax-Estimation-For-Accounts
…99-Show-estimated-tax-for-taxable-countries
…M-13999-Show-estimated-tax-for-taxable-countries
New Issues
Fixed Issues
|
…taxable-countries' into PM-13999-Show-estimated-tax-for-taxable-countries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, it's looking good! I left only a few comments, mostly ⛏️ with a few higher ones.
src/Core/Billing/Models/Api/Requests/Organizations/PreviewOrganizationInvoiceRequestModel.cs
Outdated
Show resolved
Hide resolved
…taxable-countries' into PM-13999-Show-estimated-tax-for-taxable-countries
cturnbull-bitwarden
approved these changes
Dec 3, 2024
jonashendrickx
deleted the
PM-13999-Show-estimated-tax-for-taxable-countries
branch
December 4, 2024 10:45
cturnbull-bitwarden
added a commit
that referenced
this pull request
Dec 4, 2024
This reverts commit 94fdfa4.
jonashendrickx
restored the
PM-13999-Show-estimated-tax-for-taxable-countries
branch
December 4, 2024 14:29
jonashendrickx
added a commit
that referenced
this pull request
Dec 4, 2024
…5109) This reverts commit 94fdfa4. Co-authored-by: Conner Turnbull <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13999
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes