Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PM-13999] Show estimated tax for taxable countries" #5109

Conversation

jonashendrickx
Copy link
Member

Reverts #5077

@jonashendrickx jonashendrickx requested a review from a team as a code owner December 4, 2024 14:29
@jonashendrickx jonashendrickx enabled auto-merge (squash) December 4, 2024 14:33
@jonashendrickx jonashendrickx merged commit 90a9473 into main Dec 4, 2024
45 checks passed
@jonashendrickx jonashendrickx deleted the revert-5077-PM-13999-Show-estimated-tax-for-taxable-countries branch December 4, 2024 14:36
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 38.59649% with 140 lines in your changes missing coverage. Please review.

Project coverage is 43.14%. Comparing base (470a126) to head (dcde927).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Billing/Models/TaxInformation.cs 4.22% 66 Missing and 2 partials ⚠️
src/Core/Models/Business/TaxInfo.cs 59.48% 46 Missing and 1 partial ⚠️
...e/Services/Implementations/StripePaymentService.cs 29.16% 17 Missing ⚠️
...vices/Implementations/PremiumUserBillingService.cs 20.00% 4 Missing ⚠️
...ices/Implementations/OrganizationBillingService.cs 25.00% 3 Missing ⚠️
...ling/Services/Implementations/SubscriberService.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5109      +/-   ##
==========================================
- Coverage   43.65%   43.14%   -0.52%     
==========================================
  Files        1433     1424       -9     
  Lines       66029    64919    -1110     
  Branches     5969     5936      -33     
==========================================
- Hits        28827    28010     -817     
+ Misses      35958    35666     -292     
+ Partials     1244     1243       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Logo
Checkmarx One – Scan Summary & Details6cf8e047-069f-4f8d-918c-b115d0cf0ae9

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Billing/Controllers/InvoicesController.cs: 16
MEDIUM CSRF /src/Api/Billing/Controllers/AccountsBillingController.cs: 83
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 301
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 823
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationsController.cs: 105
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 17
LOW Log_Forging /src/Api/Billing/Controllers/InvoicesController.cs: 20
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83
LOW Log_Forging /src/Api/Billing/Controllers/AccountsBillingController.cs: 83
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 184
LOW Log_Forging /src/Api/AdminConsole/Controllers/OrganizationsController.cs: 169
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/ProviderBillingController.cs: 104
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 166
LOW Log_Forging /src/Api/Billing/Controllers/OrganizationBillingController.cs: 256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants