Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the potential fun flip in HMC #284

Closed
junpenglao opened this issue Sep 17, 2022 · 4 comments · Fixed by #463
Closed

Refactor the potential fun flip in HMC #284

junpenglao opened this issue Sep 17, 2022 · 4 comments · Fixed by #463
Assignees
@junpenglao
Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality
Milestone
1.0

Comments

@junpenglao
Copy link
Member

We internally flip the sign of log_prob_fn and use potential_fun instead - this start to create more headache in the code base, we should refactor to use log_prob_fn directly.
@rlouf rlouf added refactoring Change that adds no functionality but improves code quality enhancement New feature or request labels Sep 17, 2022
@rlouf
Copy link
Member

rlouf commented Sep 17, 2022

I'm not sure I'm ready to forego the physical system analogy in the code.

@junpenglao
Copy link
Member Author

Think of it this way: you can get rid of 100s lines of codes

@rlouf
Copy link
Member

rlouf commented Sep 17, 2022

100s? I see max 20?

@rlouf rlouf added this to the 1.0 milestone Oct 24, 2022
@rlouf
Copy link
Member

rlouf commented Oct 24, 2022

Even if it doesn't remove many lines of code this is nevertheless a simplifying change. You were right, adding this to the 1.0 milestone as this would be a breaking change for those using the internals.

@junpenglao junpenglao self-assigned this Jan 15, 2023
junpenglao added a commit that referenced this issue Jan 15, 2023
@junpenglao
Refactor the potential fun flip in HMC
2d09392 
Fixes #284
@junpenglao junpenglao mentioned this issue Jan 15, 2023
Merged
12 tasks
rlouf pushed a commit that referenced this issue Jan 16, 2023
@junpenglao @rlouf
Refactor the potential fun flip in HMC
feb810f 
Fixes #284
junpenglao added a commit that referenced this issue Mar 12, 2024
@junpenglao
Refactor the potential fun flip in HMC
bc140d4 
Fixes #284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junpenglao junpenglao

Labels
enhancement New feature or request refactoring Change that adds no functionality but improves code quality
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Refactor the potential fun flip in HMC blackjax-devs/blackjax
2 participants
@rlouf @junpenglao