Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the potential fun flip in HMC #463

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Refactor the potential fun flip in HMC #463

merged 1 commit into from
Jan 16, 2023

Conversation

junpenglao
Copy link
Member

@junpenglao junpenglao commented Jan 15, 2023

Internal clean up: refactor the use age of potential function and the conversion of logdensity function to potential function in the library.

Fixes #284

Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

  • If I add a new sampler, there is an issue discussing it already;
  • We should be able to understand what the PR does from its title only;
  • There is a high-level description of the changes;
  • There are links to all the relevant issues, discussions and PRs;
  • The branch is rebased on the latest main commit;
  • Commit messages follow these guidelines;
  • The code respects the current naming conventions;
  • Docstrings follow the numpy style guide
  • pre-commit is installed and configured on your machine, and you ran it before opening the PR;
  • There are tests covering the changes;
  • The doc is up-to-date;
  • If I add a new sampler* I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #463 (2d09392) into main (27d981e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
- Coverage   99.25%   99.16%   -0.09%     
==========================================
  Files          47       48       +1     
  Lines        1872     1923      +51     
==========================================
+ Hits         1858     1907      +49     
- Misses         14       16       +2     
Impacted Files Coverage Δ
blackjax/smc/base.py 100.00% <ø> (ø)
blackjax/adaptation/meads.py 100.00% <100.00%> (ø)
blackjax/kernels.py 99.20% <100.00%> (-0.38%) ⬇️
blackjax/mcmc/elliptical_slice.py 95.00% <100.00%> (ø)
blackjax/mcmc/ghmc.py 100.00% <100.00%> (ø)
blackjax/mcmc/hmc.py 100.00% <100.00%> (ø)
blackjax/mcmc/integrators.py 100.00% <100.00%> (ø)
blackjax/mcmc/nuts.py 100.00% <100.00%> (ø)
blackjax/mcmc/periodic_orbital.py 100.00% <100.00%> (ø)
blackjax/mcmc/proposal.py 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rlouf rlouf merged commit feb810f into main Jan 16, 2023
@rlouf rlouf deleted the junpenglao/issue284 branch January 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the potential fun flip in HMC
2 participants