-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper splitting of PRNG key #526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Let's follow the official jax style and do:
key, *multiple_subkeys = random.split(key, num=k)
where key
will get pass down to the next split
while multiple_subkeys
would be used in random call.
46fa7d5
to
f64fbd8
Compare
Changed. |
f64fbd8
to
0cd54c3
Compare
There are some flaky tests - try playing around with the seed to make them past for now and leave a TODO there |
cdc0ca0
to
69de189
Compare
I believe the current test is just lucky to pass. In fact, I have run |
69de189
to
34cb365
Compare
Codecov Report
@@ Coverage Diff @@
## main #526 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 47 47
Lines 1948 1948
=======================================
Hits 1934 1934
Misses 14 14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Co-authored-by: Junpeng Lao <[email protected]>
No description provided.