suites: simplify code

If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200

lib/devos/mkProfileAttrs.nix

@@ -11,6 +11,19 @@ let mkProfileAttrs =
   Example:
   let profiles = mkProfileAttrs ./profiles; in
   assert profiles ? core.default; 0
+
+  Example folder layout:
+  profiles/core/default.nix
+  profiles/core/sub/default.nix
+  profiles/code/ignored-no-default-nix/
+  profiles/other/default.nix
+
+  Example result:
+  {
+    core = { default = "..." };
+    sub = { default = "..." };
+    other = { default = "..." };
+  }
   **/
   dir:
   let

suites/default.nix

@@ -5,19 +5,15 @@ let
   profiles = dev.os.mkProfileAttrs (toString ../profiles);
   users = dev.os.mkProfileAttrs (toString ../users);
 
-  allProfiles =
-    let defaults = lib.collect (x: x ? default) profiles;
-    in map (x: x.default) defaults;
+  allProfiles = dev.os.profileMap (lib.attrVals profiles);
 
-  allUsers =
-    let defaults = lib.collect (x: x ? default) users;
-    in map (x: x.default) defaults;
+  allUsers = dev.os.profileMap (lib.attrVals users);
 
 
   suites = with profiles; rec {
-    base = [ users.nixos users.root ];
+    base = dev.os.profileMap [ users.nixos users.root ];
   };
 in
-lib.mapAttrs (_: v: dev.os.profileMap v) suites // {
+suites // {
   inherit allProfiles allUsers;
 }