Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential naming clash #200

Closed
blaggacao opened this issue Mar 18, 2021 · 2 comments
Closed

potential naming clash #200

blaggacao opened this issue Mar 18, 2021 · 2 comments

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Mar 18, 2021 •
edited
Loading

https://github.com/divnix/devos/blob/2961c1ea529a98296be9c0f07a08431665bb8654/lib/devos/mkProfileAttrs.nix#L30

this attribute could be called profile instead, since this naming scheme precludes people naming their sub profile default — which people might actually want to do.

Is my analysis correct, here?
@blaggacao

This comment has been minimized.

Sign in to view
@blaggacao blaggacao reopened this Mar 18, 2021
@blaggacao
Copy link
Contributor Author

since this naming scheme precludes people naming their sub profile default — which people might actually want to do.

I realized that this restriction only applies for sub profiles, a top level profile still can be named default, as I understand things.

naming a sub level profile default alongside a default.nix is probably not going to happen:

core/
core/default.nix
core/default/default.nix

... improbable.

blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
e227b94 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
@blaggacao blaggacao mentioned this issue Mar 18, 2021
Closed
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
ab523ef 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
7cfb98c 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
@blaggacao blaggacao mentioned this issue Mar 18, 2021
Merged
5 tasks
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
5078fbd 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
fa64f09 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
8b61aab 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
blaggacao pushed a commit to blaggacao/devos that referenced this issue Mar 18, 2021
suites: simplify code
e76fb17 
If this code had been written this way, I wouldn't have opened divnix#200 in
the first place. (perspective of a begginer nix-langer)

closes: divnix#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

suites: simplify code blaggacao/devos
1 participant
@blaggacao