Enhance the dataset class to accept the dataset in PASCALVOC format with configuration.

[oatawa1]

What this patch does to fix the issue.

This patch adds the PASCALVOC format dataset with customization input data class functionality.

CLASSES = ['person'] # This parameters has to set a list of real class. It cannot refer to DATASET.CLASSES

# These three parameters have to set in the config file. (Now I use the VOC2007 as an example)
DATASET.CLASSES = CLASSES
DATASET.AVAILABLE_SUBSETS = ["train", "validation", "test", "train_validation"]
DATASET.EXTEND_DIR = "PASCALVOC_2007/VOCdevkit/VOC2007"

Link to any relevant issues or pull requests.

[bo-code-review-bot]

This PR needs Approvals as follows.

• Ownership Approval for / from iizukak, tkng, ruimashita
• Readability Approval for Python from tkng, tsawada, tfujiwar

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

• Approve all reviews requested to you (readability and ownership) and LGTM review
  Approval, LGTM

• Approve all ownership reviews
  Ownership Approval or OA

• Approve all readability reviews
  Readability Approval or RA

• Approve specified review targets

  • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
  • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python

• Approve LGTM review
  LGTM

See all trigger comments

Please replace [Target] to review target

• Ownership Approval
  • Ownership Approval for [Target]
  • OA for [Target]
  • Ownership Approval
  • OA
  • Approval
• Readability Approval
  • Readability Approval for [Target]
  • RA for [Target]
  • [Target] Readability Approval
  • [Target] RA
  • Readability Approval
  • RA
  • Approval
• LGTM
  • LGTM
  • lgtm

[iizukak]

Looks almost good.

[oatawa1]

@iizukak Thank you.

[iizukak]

OA

[iizukak]

@tfujiwar
I know this PR do not have unit test.
But currently, all PASCALVOC classes dose not have unit test.
So I create #1142 for add unit test and want to add unit test in other PR.

[oatawa1]

@iizukak Thank you for OA and commit.

May I ask about the debug text? Shall we remove it from the following location as well?

blueoil/blueoil/datasets/pascalvoc_2007.py

Line 83 in d9aa554

print("{} {} files and annotations are ready".format(self.__class__.__name__, self.subset))

blueoil/blueoil/datasets/pascalvoc_2012.py

Line 83 in d9aa554

print("{} {} files and annotations are ready".format(self.__class__.__name__, self.subset))

blueoil/blueoil/datasets/camvid.py

Line 279 in d9aa554

print("files and annotations are ready")

[oatawa1]

@tfujiwar I fixed all the readability, could you review this PR again?

[tfujiwar]

RA

[oatawa1]

@tfujiwar Thank you

[oatawa1]

/ready

[bo-mergebot]

⏳Merge job is queued...

[bo-mergebot]

😥Status check failed. Please fix problems and send /ready again.

[tfujiwar]

RA

[oatawa1]

@tfujiwar Thank you and sorry for request many times.

[oatawa1]

/ready

[bo-mergebot]

⏳Merge job is queued...