-
Notifications
You must be signed in to change notification settings - Fork 86
Conversation
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@primenumber
I agree with rename.
We should change these files.
$ git grep "lib_fpga" docs
docs/tutorial/image_cls.md: │ │ ├── lib_fpga.so
docs/tutorial/image_det.md: │ │ ├── lib_fpga.so
docs/tutorial/image_keypoint_detection.md:│ │ ├── lib_fpga.so
docs/tutorial/image_seg.md: │ │ ├── lib_fpga.so
docs/tutorial/run_fpga.md: │ │ └── lib_fpga.so
docs/tutorial/run_fpga.md: -m ../models/lib/lib_fpga.so \
It seems that these are already renamed...
|
wow sorry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ownership Approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readability Approval
/ready |
⏳Merge job is queued... |
close #712 .
Rename generated library name from
lib_fpga.so
tolibdlk_fpga.so
, for example.Motivation and Context
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: