Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Rename lib name #724

Merged
merged 7 commits into from
Feb 14, 2020
Merged

Rename lib name #724

merged 7 commits into from
Feb 14, 2020

Conversation

primenumber
Copy link
Contributor

close #712 .

Rename generated library name from lib_fpga.so to libdlk_fpga.so, for example.

Motivation and Context

Description

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@primenumber primenumber requested a review from tkng January 14, 2020 09:21
@primenumber primenumber self-assigned this Jan 14, 2020
@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Jan 14, 2020
@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

@primenumber primenumber added the CI: test-lmnet Run lmnet test once label Jan 15, 2020
@blueoil-butler blueoil-butler bot removed the CI: test-lmnet Run lmnet test once label Jan 15, 2020
Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@primenumber
I agree with rename.
We should change these files.

$ git grep "lib_fpga" docs
docs/tutorial/image_cls.md: │   │   ├── lib_fpga.so
docs/tutorial/image_det.md: │   │   ├── lib_fpga.so
docs/tutorial/image_keypoint_detection.md:│   │   ├── lib_fpga.so
docs/tutorial/image_seg.md: │   │   ├── lib_fpga.so
docs/tutorial/run_fpga.md: │   │   └── lib_fpga.so
docs/tutorial/run_fpga.md:          -m ../models/lib/lib_fpga.so \

@primenumber
Copy link
Contributor Author

@primenumber
I agree with rename.
We should change these files.

$ git grep "lib_fpga" docs
docs/tutorial/image_cls.md: │   │   ├── lib_fpga.so
docs/tutorial/image_det.md: │   │   ├── lib_fpga.so
docs/tutorial/image_keypoint_detection.md:│   │   ├── lib_fpga.so
docs/tutorial/image_seg.md: │   │   ├── lib_fpga.so
docs/tutorial/run_fpga.md: │   │   └── lib_fpga.so
docs/tutorial/run_fpga.md:          -m ../models/lib/lib_fpga.so \

It seems that these are already renamed...

$ git grep "lib_fpga" docs
$

@iizukak
Copy link
Member

iizukak commented Jan 24, 2020

wow sorry

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ownership Approval

@primenumber primenumber requested a review from tsawada February 14, 2020 08:36
Copy link
Contributor

@tsawada tsawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability Approval

@primenumber
Copy link
Contributor Author

/ready

@bo-mergebot
Copy link
Contributor

bo-mergebot bot commented Feb 14, 2020

⏳Merge job is queued...

@bo-mergebot bo-mergebot bot merged commit da605d6 into blue-oil:master Feb 14, 2020
@primenumber primenumber deleted the rename-lib-name branch February 17, 2020 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename generated library name
4 participants