Move lmnet/executor/train.py to blueoil/cmd #837
Conversation
|
This PR needs Approvals as follows.
Please choose reviewers and requet reviews! Click to see how to approve each reviewsYou can approve this PR by triggered comments as follows.
See all trigger commentsPlease replace [Target] to review target
|
blueoil/cmd/main.py
Outdated
| @click.option( | ||
| '-n', | ||
| '--network', | ||
| help='Network name which you want to use for this training. override config.DATASET_CLASS', |
There was a problem hiding this comment.
I don't know why we need this option.
Specify in config file is not enough?
There was a problem hiding this comment.
I also don't know why but I think we can remove this.
There was a problem hiding this comment.
I've removed the options network and dataset.
blueoil/cmd/main.py
Outdated
| @click.option( | ||
| '-d', | ||
| '--dataset', | ||
| help='Dataset name which is the source of this training. override config.NETWORK_CLASS', |
| return DatasetIterator(dataset, seed=rank, enable_prefetch=enable_prefetch) | ||
|
|
||
|
|
||
| def start_training(config): |
There was a problem hiding this comment.
This function is too long, But it's copied from original train.py.
We will refactor in other PR.
|
/ready |
|
⏳Merge job is queued... |
What this patch does to fix the issue.
This PR looks big but most of the changes are just copied. Maybe it's easier to check each commit one by one than checking the whole changes.
Link to any relevant issues or pull requests.
#746