Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Move lmnet/executor/train.py to blueoil/cmd #837

Merged
merged 5 commits into from
Feb 13, 2020
Merged

Move lmnet/executor/train.py to blueoil/cmd #837

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
77d102a
Remove blueoil/cmd/train.py
Feb 13, 2020
d0dbd45
Move lmnet/executor/train.py to blueoil/cmd
Feb 13, 2020
749daf9
Update blueoil/cmd/train.py
Feb 13, 2020
5b886ab
Remove options "network" and "dataset" from train command
Feb 13, 2020
92904e4
Merge branch 'master' into move-train
bo-mergebot[bot] Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions blueoil/cmd/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,27 @@ def init(output):
'--experiment_id',
help='ID of this training.',
default=None,
required=False,
)
def train(config, experiment_id=None):
experiment_id, checkpoint_name = run_train(config, experiment_id)
@click.option(
'--recreate',
is_flag=True,
help='Delete and recreate experiment id dir',
default=False,
)
@click.option(
'-n',
'--network',
help='Network name which you want to use for this training. override config.DATASET_CLASS',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we need this option.
Specify in config file is not enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't know why but I think we can remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the options network and dataset.

default=None,
)
@click.option(
'-d',
'--dataset',
help='Dataset name which is the source of this training. override config.NETWORK_CLASS',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question.

default=None,
)
def train(config, experiment_id, recreate, network, dataset):
experiment_id, checkpoint_name = run_train(config, experiment_id, recreate, network, dataset)
click.echo('Next step: blueoil convert -e {} -p {}'.format(
experiment_id,
checkpoint_name
Expand Down
Loading