Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close connections in case of write errors (#613) #655

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Dec 14, 2024

Replaces #613

@aler9 aler9 mentioned this pull request Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 85.32609% with 27 lines in your changes missing coverage. Please review.

Project coverage is 82.47%. Comparing base (a2df9d8) to head (262cd58).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
client.go 83.01% 9 Missing ⚠️
server_session.go 80.85% 9 Missing ⚠️
async_processor.go 72.22% 3 Missing and 2 partials ⚠️
client_reader.go 80.00% 2 Missing ⚠️
server_conn_reader.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   82.46%   82.47%   +0.01%     
==========================================
  Files         116      116              
  Lines       11804    11847      +43     
==========================================
+ Hits         9734     9771      +37     
- Misses       1683     1688       +5     
- Partials      387      388       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 8f74559 into main Dec 14, 2024
9 checks passed
@aler9 aler9 deleted the fix/write-err branch December 14, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant