Fix writer nullpointer panic on network reconnect #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #655 the change was made in
client.go
to setwriter
tonil
, before completing the 'closing' of the client. This makes that if someone callsWritePacketRTPWithNTP
afterwriter = nil
but beforec.done
is closed, there is a panic. As described in #678.I don't fully understand why
c.writer = nil
is needed in the first place. It seems that before #655c.writer
is never set tonil
. And after testing the situation of the panic, this resolved it. If someone has a better solution I'm very eager to learn!