Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow form of # months (#mo) is untranslatable to Italian #6817

Open
mlocati opened this issue Nov 28, 2024 · 2 comments · May be fixed by #7744
Open

Narrow form of # months (#mo) is untranslatable to Italian #6817

mlocati opened this issue Nov 28, 2024 · 2 comments · May be fixed by #7744
Labels
bug Something isn't working

Comments

@mlocati
Copy link
Contributor

mlocati commented Nov 28, 2024

Steps to Reproduce

When viewing posts that are months old, Bluesky presents a narrow form of the "number of months".

Here's an example that displays "1 month" in this narrow form:

immagine

In Italian we don't have a narrow form for months, probably because it's already rather short (singular: mese, plural: mesi).

The problem is that Bluesky doesn't support specifying plural forms - see
https://github.com/bluesky-social/social-app/blob/1.95.0/src/lib/hooks/useTimeAgo.ts#L170

  • {0}mese doesn't work for > 1 months (it's like reading "2month" in English)
  • {0}mesi doesn't work for 1 month (it's like reading "1months" in English)

At the moment we have {0}mesi, but it's really ugly to see this:

immagine

Attachments

No response

What platform(s) does this occur on?

Android, Web (Desktop)

Device Info

No response

What version of the app are you using?

Build version: 1.95.0; Bundle info: c9d86de (prod); Bundle date: 24112719; Platform: web; Platform version: undefined

Additional Information

No response

@mlocati mlocati added the bug Something isn't working label Nov 28, 2024
claudioc added a commit to claudioc/social-app that referenced this issue Nov 28, 2024
@c960657
Copy link
Contributor

c960657 commented Dec 21, 2024

FWIW, CLDR just uses the full form, {0} mese/{0} mesi.

https://github.com/unicode-org/cldr/blob/57e30cab4/common/main/it.xml#L2466-L2469

@mlocati
Copy link
Contributor Author

mlocati commented Dec 21, 2024

Yep, supporting plural forms would solve the issue. But also avoiding the "X months ago" approach and instead displaying a date would work.

@surfdude29 surfdude29 linked a pull request Feb 14, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants