nlprule-build: sure cursor is not seek'd all to the end #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since transform data is short lived, the input data, input can be bound by 'r as well.
3 tasks
|
@bminixhofer I would like for this to be included asap, it's fallout of #35 |
bminixhofer
reviewed
Feb 20, 2021
|
Thanks for being so on top of this, much appreciated! |
drahnr
added a commit
to drahnr/nlprule
that referenced
this pull request
Apr 7, 2021
* make sure cursor is not at the end already Since transform data is short lived, the input data, input can be bound by 'r as well. * add another missing seek back to 0 * assure test data is decoded successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the cursor was passed twice as
&mut Cursorwhich lead to the second usage failing, since it was already read to the end.Replaced by
&mut v.as_slice()which is cheaper and does not have to be seek'd back to start.Since transform data is short lived, the input data of
TransformDataFnmust be bound to'r, which is commonly equiv'w, but that restriction should be left to the user.