Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include artifacts #151

Merged
merged 6 commits into from
Feb 20, 2021
Merged

include artifacts #151

merged 6 commits into from
Feb 20, 2021

Conversation

drahnr
Copy link
Owner

@drahnr drahnr commented Feb 20, 2021

What does this PR accomplish?

  • 🩹 Bug Fix
  • 🦚 Feature

Changes proposed by this PR:

Add all the binary files used by nlprule directly to the crate and publish them to crates.io as well. Zero external dependencies!

Notes to reviewer:

Requires bminixhofer/nlprule#39 to land a probably a dep update to 0.4.6 then.

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@drahnr drahnr changed the title Bernhard include artifacts include artifacts Feb 20, 2021
@drahnr drahnr merged commit f5c0f3c into master Feb 20, 2021
@drahnr drahnr deleted the bernhard-include-artifacts branch February 20, 2021 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant